Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Stats Array #5750

Closed
wants to merge 4 commits into from

Conversation

xu-shawn
Copy link
Contributor

@xu-shawn xu-shawn commented Jan 6, 2025

  • Limit use of StatsEntry wrapper to arithmetic types
  • Generalize Stats to MultiArray by discarding the template parameter D
  • Allow MultiArray::fill to take any type assignable to element type
  • Remove now-unused operator overloads on StatsEntry

no functional change

bench 999324
@Disservin
Copy link
Member

id prefer if the usage says the same, i.e. use

template<typename T, int D, std::size_t... Sizes>
using Stats = MultiArray<StatsEntry<T, D>, Sizes...>;

and drop the CorrHistEntry and HistoryEntry

bench 999324
no functional change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants